Horton

Thread

Commits

  1. Improve comment in gram.y.

  1. Unable parse a comment in gram.y

    Tatsuo Ishii <ishii@sraoss.co.jp> — 2024-06-23T04:01:54Z

    I was unable to parse a comment in src/backend/parser/gram.y around line 11364:

/*
 * As func_expr but does not accept WINDOW functions directly (they
 * can still be contained in arguments for functions etc.)
 * Use this when window expressions are not allowed, so to disambiguate
 * the grammar. (e.g. in CREATE INDEX)
 */

Maybe "but" is unnecessary in the first sentence in the comment?

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

  2. Re: Unable parse a comment in gram.y

    David G. Johnston <david.g.johnston@gmail.com> — 2024-06-23T04:13:37Z

    On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> I was unable to parse a comment in src/backend/parser/gram.y around line
> 11364:
>
> /*
>  * As func_expr but does not accept WINDOW functions directly (they
>  * can still be contained in arguments for functions etc.)
>  * Use this when window expressions are not allowed, so to disambiguate
>  * the grammar. (e.g. in CREATE INDEX)
>  */
>
> Maybe "but" is unnecessary in the first sentence in the comment?
>
>
The "but" is required, add a comma before it.  It could also be written a
bit more verbosely:

func_expr_windowless is the same as func_expr aside from not accepting
window functions directly ...

David J.

  3. Re: Unable parse a comment in gram.y

    Tatsuo Ishii <ishii@sraoss.co.jp> — 2024-06-23T04:22:10Z

    > On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
> 
>> I was unable to parse a comment in src/backend/parser/gram.y around line
>> 11364:
>>
>> /*
>>  * As func_expr but does not accept WINDOW functions directly (they
>>  * can still be contained in arguments for functions etc.)
>>  * Use this when window expressions are not allowed, so to disambiguate
>>  * the grammar. (e.g. in CREATE INDEX)
>>  */
>>
>> Maybe "but" is unnecessary in the first sentence in the comment?
>>
>>
> The "but" is required, add a comma before it.  It could also be written a
> bit more verbosely:
> 
> func_expr_windowless is the same as func_expr aside from not accepting
> window functions directly ...

Oh, I see.
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

  4. Re: Unable parse a comment in gram.y

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-06-23T04:41:29Z

    "David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> I was unable to parse a comment in src/backend/parser/gram.y around line
>> 11364:
>> 
>> * As func_expr but does not accept WINDOW functions directly (they
>> * can still be contained in arguments for functions etc.)

> The "but" is required, add a comma before it.  It could also be written a
> bit more verbosely:

Perhaps s/As func_expr/Like func_expr/ would be less confusing?

			regards, tom lane

  5. Re: Unable parse a comment in gram.y

    Tatsuo Ishii <ishii@sraoss.co.jp> — 2024-06-23T05:11:35Z

    >>> * As func_expr but does not accept WINDOW functions directly (they
>>> * can still be contained in arguments for functions etc.)
> 
>> The "but" is required, add a comma before it.  It could also be written a
>> bit more verbosely:
> 
> Perhaps s/As func_expr/Like func_expr/ would be less confusing?

+1. It's easier to understand at least for me.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

  6. Re: Unable parse a comment in gram.y

    David G. Johnston <david.g.johnston@gmail.com> — 2024-06-23T06:19:52Z

    On Saturday, June 22, 2024, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> >>> * As func_expr but does not accept WINDOW functions directly (they
> >>> * can still be contained in arguments for functions etc.)
> >
> >> The "but" is required, add a comma before it.  It could also be written
> a
> >> bit more verbosely:
> >
> > Perhaps s/As func_expr/Like func_expr/ would be less confusing?
>
> +1. It's easier to understand at least for me.
>
>
+1

David J.

  7. Re: Unable parse a comment in gram.y

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-06-23T16:59:57Z

    "David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Saturday, June 22, 2024, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>>> Perhaps s/As func_expr/Like func_expr/ would be less confusing?

>> +1. It's easier to understand at least for me.

> +1

OK.  I looked through the rest of src/backend/parser/ and couldn't
find any other similar wording.  There's plenty of "As with ..."
and "As in ...", but at least to me those don't seem confusing.
I'll plan to push the attached after the release freeze lifts.

			regards, tom lane

  8. Re: Unable parse a comment in gram.y

    Tatsuo Ishii <ishii@sraoss.co.jp> — 2024-06-24T00:23:37Z

    >>> +1. It's easier to understand at least for me.
> 
>> +1
> 
> OK.  I looked through the rest of src/backend/parser/ and couldn't
> find any other similar wording.  There's plenty of "As with ..."
> and "As in ...", but at least to me those don't seem confusing.
> I'll plan to push the attached after the release freeze lifts.

Excellent!
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp