Re: Unable parse a comment in gram.y

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>, pgsql-hackers@postgresql.org
Date: 2024-06-23T04:41:29Z
Lists: pgsql-hackers
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>> I was unable to parse a comment in src/backend/parser/gram.y around line
>> 11364:
>> 
>> * As func_expr but does not accept WINDOW functions directly (they
>> * can still be contained in arguments for functions etc.)

> The "but" is required, add a comma before it.  It could also be written a
> bit more verbosely:

Perhaps s/As func_expr/Like func_expr/ would be less confusing?

			regards, tom lane



Commits

  1. Improve comment in gram.y.