Horton

Re: Unable parse a comment in gram.y

David G. Johnston <david.g.johnston@gmail.com>

View thread View on postgr.es
From: "David G. Johnston" <david.g.johnston@gmail.com>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-06-23T06:19:52Z
Lists: pgsql-hackers 
On Saturday, June 22, 2024, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> >>> * As func_expr but does not accept WINDOW functions directly (they
> >>> * can still be contained in arguments for functions etc.)
> >
> >> The "but" is required, add a comma before it.  It could also be written
> a
> >> bit more verbosely:
> >
> > Perhaps s/As func_expr/Like func_expr/ would be less confusing?
>
> +1. It's easier to understand at least for me.
>
>
+1

David J.

Commits

  1. Improve comment in gram.y.