Re: Unable parse a comment in gram.y

On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> I was unable to parse a comment in src/backend/parser/gram.y around line
> 11364:
>
> /*
>  * As func_expr but does not accept WINDOW functions directly (they
>  * can still be contained in arguments for functions etc.)
>  * Use this when window expressions are not allowed, so to disambiguate
>  * the grammar. (e.g. in CREATE INDEX)
>  */
>
> Maybe "but" is unnecessary in the first sentence in the comment?
>
>
The "but" is required, add a comma before it.  It could also be written a
bit more verbosely:

func_expr_windowless is the same as func_expr aside from not accepting
window functions directly ...

David J.