Re: Unable parse a comment in gram.y
Tatsuo Ishii <ishii@sraoss.co.jp>
From: Tatsuo Ishii <ishii@sraoss.co.jp>
To: david.g.johnston@gmail.com
Cc: pgsql-hackers@postgresql.org
Date: 2024-06-23T04:22:10Z
Lists: pgsql-hackers
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote: > >> I was unable to parse a comment in src/backend/parser/gram.y around line >> 11364: >> >> /* >> * As func_expr but does not accept WINDOW functions directly (they >> * can still be contained in arguments for functions etc.) >> * Use this when window expressions are not allowed, so to disambiguate >> * the grammar. (e.g. in CREATE INDEX) >> */ >> >> Maybe "but" is unnecessary in the first sentence in the comment? >> >> > The "but" is required, add a comma before it. It could also be written a > bit more verbosely: > > func_expr_windowless is the same as func_expr aside from not accepting > window functions directly ... Oh, I see. -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
Commits
-
Improve comment in gram.y.
- 1bf29f51fa1a 17.0 landed