Re: Unable parse a comment in gram.y
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-06-23T16:59:57Z
Lists: pgsql-hackers
Attachments
- improve-comment-in-gram.y.patch (text/x-diff) patch
"David G. Johnston" <david.g.johnston@gmail.com> writes: > On Saturday, June 22, 2024, Tatsuo Ishii <ishii@sraoss.co.jp> wrote: >>> Perhaps s/As func_expr/Like func_expr/ would be less confusing? >> +1. It's easier to understand at least for me. > +1 OK. I looked through the rest of src/backend/parser/ and couldn't find any other similar wording. There's plenty of "As with ..." and "As in ...", but at least to me those don't seem confusing. I'll plan to push the attached after the release freeze lifts. regards, tom lane
Commits
-
Improve comment in gram.y.
- 1bf29f51fa1a 17.0 landed