Horton

Thread

Commits

  1. Improve "out of range" error messages for GUCs.

  1. slightly misleading Error message in guc.c

    jian he <jian.universality@gmail.com> — 2024-04-22T08:43:42Z

    hi.
minor issue in guc.c.

set work_mem to '1kB';
ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
.. 2147483647)
should it be
ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
kB .. 2147483647 kB)
?
since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}

search `outside the valid range for parameter`,
there are two occurrences in guc.c.

  2. Re: slightly misleading Error message in guc.c

    Nazir Bilal Yavuz <byavuz81@gmail.com> — 2024-04-22T14:08:05Z

    Hi,

On Mon, 22 Apr 2024 at 11:44, jian he <jian.universality@gmail.com> wrote:
>
> hi.
> minor issue in guc.c.
>
> set work_mem to '1kB';
> ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
> .. 2147483647)
> should it be
> ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
> kB .. 2147483647 kB)
> ?
> since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}
>
> search `outside the valid range for parameter`,
> there are two occurrences in guc.c.

Nice find. I agree it could cause confusion.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft

  3. Re: slightly misleading Error message in guc.c

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-04-22T16:04:55Z

    jian he <jian.universality@gmail.com> writes:
> set work_mem to '1kB';
> ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
> .. 2147483647)
> should it be
> ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
> kB .. 2147483647 kB)
> ?
> since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}

Seems like a useful change ... about like this?

			regards, tom lane

  4. Re: slightly misleading Error message in guc.c

    Daniel Gustafsson <daniel@yesql.se> — 2024-04-23T12:21:52Z

    > On 22 Apr 2024, at 18:04, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Seems like a useful change

Agreed.

> ... about like this?

Patch LGTM.

--
Daniel Gustafsson

  5. Re: slightly misleading Error message in guc.c

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-04-23T15:53:21Z

    Daniel Gustafsson <daniel@yesql.se> writes:
>> On 22 Apr 2024, at 18:04, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Seems like a useful change

> Agreed.

>> ... about like this?

> Patch LGTM.

Pushed.

			regards, tom lane