Horton

Re: slightly misleading Error message in guc.c

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-22T16:04:55Z
Lists: pgsql-hackers

Attachments

jian he <jian.universality@gmail.com> writes:
> set work_mem to '1kB';
> ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
> .. 2147483647)
> should it be
> ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
> kB .. 2147483647 kB)
> ?
> since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}

Seems like a useful change ... about like this?

			regards, tom lane

Commits

  1. Improve "out of range" error messages for GUCs.