Re: slightly misleading Error message in guc.c
Nazir Bilal Yavuz <byavuz81@gmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-22T14:08:05Z
Lists: pgsql-hackers
Hi,
On Mon, 22 Apr 2024 at 11:44, jian he <jian.universality@gmail.com> wrote:
>
> hi.
> minor issue in guc.c.
>
> set work_mem to '1kB';
> ERROR: 1 kB is outside the valid range for parameter "work_mem" (64
> .. 2147483647)
> should it be
> ERROR: 1 kB is outside the valid range for parameter "work_mem" (64
> kB .. 2147483647 kB)
> ?
> since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}
>
> search `outside the valid range for parameter`,
> there are two occurrences in guc.c.
Nice find. I agree it could cause confusion.
--
Regards,
Nazir Bilal Yavuz
Microsoft
Commits
-
Improve "out of range" error messages for GUCs.
- bb3ca2323986 17.0 landed