Horton

slightly misleading Error message in guc.c

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-04-22T08:43:42Z
Lists: pgsql-hackers 
hi.
minor issue in guc.c.

set work_mem to '1kB';
ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
.. 2147483647)
should it be
ERROR:  1 kB is outside the valid range for parameter "work_mem" (64
kB .. 2147483647 kB)
?
since the units for work_mem are { "B", "kB", "MB", "GB", and "TB"}

search `outside the valid range for parameter`,
there are two occurrences in guc.c.

Commits

  1. Improve "out of range" error messages for GUCs.