Thread
Commits
-
Remove unused xid parameter.
- af51b2f042a0 16.0 landed
-
Don't force-assign transaction id when exporting a snapshot.
- 6c2003f8a1bb 10.0 cited
-
Removing unused parameter in SnapBuildGetOrBuildSnapshot
Melih Mutlu <m.melihmutlu@gmail.com> — 2022-09-21T14:21:57Z
Hi hackers, Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless. I couldn't see a reason to keep it and decided to remove it. Regards, Melih
-
Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Zhang Mingli <zmlpostgres@gmail.com> — 2022-09-21T14:41:20Z
On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote: > Hi hackers, > > Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c > > With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless. > I couldn't see a reason to keep it and decided to remove it. > > Regards, > Melih +1, Good Catch. Regards, Zhang Mingli
-
Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Amit Kapila <amit.kapila16@gmail.com> — 2022-09-23T03:28:17Z
On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli <zmlpostgres@gmail.com> wrote: > > On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote: > > Hi hackers, > > Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c > > With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless. > I couldn't see a reason to keep it and decided to remove it. > > Regards, > Melih > > +1, Good Catch. > LGTM. -- With Regards, Amit Kapila.
-
Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot
Amit Kapila <amit.kapila16@gmail.com> — 2022-09-26T04:22:00Z
On Fri, Sep 23, 2022 at 8:58 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli <zmlpostgres@gmail.com> wrote: > > > > On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote: > > > > Hi hackers, > > > > Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c > > > > > > +1, Good Catch. > > > > LGTM. > Pushed. -- With Regards, Amit Kapila.