Horton

Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Zhang Mingli <zmlpostgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Melih Mutlu <m.melihmutlu@gmail.com>
Date: 2022-09-23T03:28:17Z
Lists: pgsql-hackers 
On Wed, Sep 21, 2022 at 8:11 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
>
> On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
>
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless.
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
>
> +1, Good Catch.
>

LGTM.

-- 
With Regards,
Amit Kapila.

Commits

  1. Remove unused xid parameter.

  2. Don't force-assign transaction id when exporting a snapshot.