Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot

Zhang Mingli <zmlpostgres@gmail.com>

From: Zhang Mingli <zmlpostgres@gmail.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>, Melih Mutlu <m.melihmutlu@gmail.com>

Date: 2022-09-21T14:41:20Z

Lists: pgsql-hackers

On Sep 21, 2022, 22:22 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
> Hi hackers,
>
> Sharing a small patch to remove an unused parameter in SnapBuildGetOrBuildSnapshot function in snapbuild.c
>
> With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f, SnapBuildBuildSnapshot no longer needs transaction id. This also makes the xid parameter in SnapBuildGetOrBuildSnapshot useless.
> I couldn't see a reason to keep it and decided to remove it.
>
> Regards,
> Melih
+1, Good Catch.

Regards,
Zhang Mingli

Commits

Remove unused xid parameter.
- af51b2f042a0 16.0 landed
Don't force-assign transaction id when exporting a snapshot.
- 6c2003f8a1bb 10.0 cited