Removing unused parameter in SnapBuildGetOrBuildSnapshot

Melih Mutlu <m.melihmutlu@gmail.com>

From: Melih Mutlu <m.melihmutlu@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-09-21T14:21:57Z
Lists: pgsql-hackers

Attachments

Hi hackers,

Sharing a small patch to remove an unused parameter
in SnapBuildGetOrBuildSnapshot function in snapbuild.c

With commit 6c2003f8a1bbc7c192a2e83ec51581c018aa162f,
SnapBuildBuildSnapshot no longer needs transaction id. This also makes the
xid parameter in SnapBuildGetOrBuildSnapshot useless.
I couldn't see a reason to keep it and decided to remove it.

Regards,
Melih

Commits

  1. Remove unused xid parameter.

  2. Don't force-assign transaction id when exporting a snapshot.