Horton

Thread

Commits

  1. Apply COPT to CXXFLAGS as well

  1. CompilerWarnings task does not catch C++ warnings

    Peter Eisentraut <peter@eisentraut.org> — 2024-06-18T07:27:02Z

    The CompilerWarnings task on Cirrus CI does not catch warnings in C++ 
code.  It tries to make warnings fatal by passing COPT='-Werror', but 
that does not apply to C++ compilations.

I suggest that we just add COPT to CXXFLAGS as well.  I think passing 
-Werror is just about the only reasonable use of COPT nowadays, so 
making that more robust seems useful.  I don't think there is a need for 
a separate make variable for C++ here.

  2. Re: CompilerWarnings task does not catch C++ warnings

    Tom Lane <tgl@sss.pgh.pa.us> — 2024-06-18T14:08:11Z

    Peter Eisentraut <peter@eisentraut.org> writes:
> The CompilerWarnings task on Cirrus CI does not catch warnings in C++ 
> code.  It tries to make warnings fatal by passing COPT='-Werror', but 
> that does not apply to C++ compilations.
> I suggest that we just add COPT to CXXFLAGS as well.  I think passing 
> -Werror is just about the only reasonable use of COPT nowadays, so 
> making that more robust seems useful.  I don't think there is a need for 
> a separate make variable for C++ here.

+1, but what about the meson side of things?

			regards, tom lane

  3. Re: CompilerWarnings task does not catch C++ warnings

    Peter Eisentraut <peter@eisentraut.org> — 2024-06-18T14:22:49Z

    On 18.06.24 16:08, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> The CompilerWarnings task on Cirrus CI does not catch warnings in C++
>> code.  It tries to make warnings fatal by passing COPT='-Werror', but
>> that does not apply to C++ compilations.
>> I suggest that we just add COPT to CXXFLAGS as well.  I think passing
>> -Werror is just about the only reasonable use of COPT nowadays, so
>> making that more robust seems useful.  I don't think there is a need for
>> a separate make variable for C++ here.
> 
> +1, but what about the meson side of things?

If you use meson {setup|configure} --werror, that would affect both C 
and C++ compilers.

  4. Re: CompilerWarnings task does not catch C++ warnings

    Andres Freund <andres@anarazel.de> — 2024-06-18T14:31:16Z

    Hi,

On 2024-06-18 09:27:02 +0200, Peter Eisentraut wrote:
> The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code.
> It tries to make warnings fatal by passing COPT='-Werror', but that does not
> apply to C++ compilations.
> 
> I suggest that we just add COPT to CXXFLAGS as well.  I think passing
> -Werror is just about the only reasonable use of COPT nowadays, so making
> that more robust seems useful.  I don't think there is a need for a separate
> make variable for C++ here.

+1

Greetings,

Andres Freund