Re: CompilerWarnings task does not catch C++ warnings
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-06-18T14:31:16Z
Lists: pgsql-hackers
Hi, On 2024-06-18 09:27:02 +0200, Peter Eisentraut wrote: > The CompilerWarnings task on Cirrus CI does not catch warnings in C++ code. > It tries to make warnings fatal by passing COPT='-Werror', but that does not > apply to C++ compilations. > > I suggest that we just add COPT to CXXFLAGS as well. I think passing > -Werror is just about the only reasonable use of COPT nowadays, so making > that more robust seems useful. I don't think there is a need for a separate > make variable for C++ here. +1 Greetings, Andres Freund
Commits
-
Apply COPT to CXXFLAGS as well
- 0c3930d07689 18.0 landed