Re: CompilerWarnings task does not catch C++ warnings
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-06-18T14:08:11Z
Lists: pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes: > The CompilerWarnings task on Cirrus CI does not catch warnings in C++ > code. It tries to make warnings fatal by passing COPT='-Werror', but > that does not apply to C++ compilations. > I suggest that we just add COPT to CXXFLAGS as well. I think passing > -Werror is just about the only reasonable use of COPT nowadays, so > making that more robust seems useful. I don't think there is a need for > a separate make variable for C++ here. +1, but what about the meson side of things? regards, tom lane
Commits
-
Apply COPT to CXXFLAGS as well
- 0c3930d07689 18.0 landed