Horton

Thread

Commits

  1. Fix PG_GETARG_SEG_P() definition.

  2. Move contrib/seg to only use V1 calling conventions.

  1. [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2019-11-02T23:14:47Z

    Hi hackers,

I just noticed that when contrib/seg was converted to V1 calling
convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
so shouldn't it be using PG_GETARG_DATUM()?

Attached is a patch that fixes it, and brings it in line with all the
other PG_GETARG_FOO_P() macros.

- ilmari
-- 
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen

  2. Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-11-03T15:58:30Z

    ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> I just noticed that when contrib/seg was converted to V1 calling
> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
> in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
> so shouldn't it be using PG_GETARG_DATUM()?

Yup, I agree.  Pushed.

			regards, tom lane

  3. Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2019-11-04T11:30:23Z

    Tom Lane <tgl@sss.pgh.pa.us> writes:

> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>> I just noticed that when contrib/seg was converted to V1 calling
>> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
>> in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
>> so shouldn't it be using PG_GETARG_DATUM()?
>
> Yup, I agree.  Pushed.

Thanks!

> 			regards, tom lane

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law

  4. Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

    Andres Freund <andres@anarazel.de> — 2019-11-04T18:01:44Z

    Hi,

On 2019-11-04 11:30:23 +0000, Dagfinn Ilmari Mannsåker wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
> 
> > ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> >> I just noticed that when contrib/seg was converted to V1 calling
> >> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
> >> in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
> >> so shouldn't it be using PG_GETARG_DATUM()?
> >
> > Yup, I agree.  Pushed.
> 
> Thanks!

Thanks both of you.

- Andres