Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker )
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2019-11-04T11:30:23Z
Lists: pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes: > ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> I just noticed that when contrib/seg was converted to V1 calling >> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined >> in terms of PG_GETARG_POINTER(). But it itself calls DatumGetPointer(), >> so shouldn't it be using PG_GETARG_DATUM()? > > Yup, I agree. Pushed. Thanks! > regards, tom lane - ilmari -- "The surreality of the universe tends towards a maximum" -- Skud's Law "Never formulate a law or axiom that you're not prepared to live with the consequences of." -- Skud's Meta-Law
Commits
-
Fix PG_GETARG_SEG_P() definition.
- 741b1aaf61a3 13.0 landed
-
Move contrib/seg to only use V1 calling conventions.
- 389bb2818f40 10.0 cited