[PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker )
To: pgsql-hackers@postgresql.org
Date: 2019-11-02T23:14:47Z
Lists: pgsql-hackers

Attachments

Hi hackers,

I just noticed that when contrib/seg was converted to V1 calling
convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
so shouldn't it be using PG_GETARG_DATUM()?

Attached is a patch that fixes it, and brings it in line with all the
other PG_GETARG_FOO_P() macros.

- ilmari
-- 
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen

Commits

  1. Fix PG_GETARG_SEG_P() definition.

  2. Move contrib/seg to only use V1 calling conventions.