Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_stat_statements: Remove duplicated tests for SET statements

  1. Doubled test for SET statements in pg_stat_statements tests

    Sergei Kornilov <sk@zsrv.org> — 2023-11-08T07:33:23Z

    Hello!

I noticed that the same block

-- SET statements.
-- These use two different strings, still they count as one entry.
SET work_mem = '1MB';
Set work_mem = '1MB';
SET work_mem = '2MB';
RESET work_mem;
SET enable_seqscan = off;
SET enable_seqscan = on;
RESET enable_seqscan;

is checked twice in contrib/pg_stat_statements/sql/utility.sql on lines 278-286 and 333-341. Is this on any purpose? I think the second set of tests is not needed and can be removed, as in the attached patch.

regards, Sergei

  2. Re: Doubled test for SET statements in pg_stat_statements tests

    Michael Paquier <michael@paquier.xyz> — 2023-11-09T03:58:04Z

    On Wed, Nov 08, 2023 at 10:33:23AM +0300, Sergei Kornilov wrote:
> is checked twice in contrib/pg_stat_statements/sql/utility.sql on
> lines 278-286 and 333-341. Is this on any purpose? I think the
> second set of tests is not needed and can be removed, as in the
> attached patch.

Thanks, applied.  This looks like a copy-paste mistake coming from
de2aca288569, even if it has added more scenarios for patterns around
SET.
--
Michael