Re: Doubled test for SET statements in pg_stat_statements tests

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Sergei Kornilov <sk@zsrv.org>

Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>

Date: 2023-11-09T03:58:04Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_stat_statements: Remove duplicated tests for SET statements
- 179c4639cf1d 16.2 landed
- 108161bcb9cc 17.0 landed

On Wed, Nov 08, 2023 at 10:33:23AM +0300, Sergei Kornilov wrote:
> is checked twice in contrib/pg_stat_statements/sql/utility.sql on
> lines 278-286 and 333-341. Is this on any purpose? I think the
> second set of tests is not needed and can be removed, as in the
> attached patch.

Thanks, applied.  This looks like a copy-paste mistake coming from
de2aca288569, even if it has added more scenarios for patterns around
SET.
--
Michael