Doubled test for SET statements in pg_stat_statements tests

Sergei Kornilov <sk@zsrv.org>

From: Sergei Kornilov <sk@zsrv.org>

To: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>

Date: 2023-11-08T07:33:23Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_stat_statements: Remove duplicated tests for SET statements
- 179c4639cf1d 16.2 landed
- 108161bcb9cc 17.0 landed

Attachments

pgss_doubled_test_for_set_statements.patch (text/x-diff) patch

Hello!

I noticed that the same block

-- SET statements.
-- These use two different strings, still they count as one entry.
SET work_mem = '1MB';
Set work_mem = '1MB';
SET work_mem = '2MB';
RESET work_mem;
SET enable_seqscan = off;
SET enable_seqscan = on;
RESET enable_seqscan;

is checked twice in contrib/pg_stat_statements/sql/utility.sql on lines 278-286 and 333-341. Is this on any purpose? I think the second set of tests is not needed and can be removed, as in the attached patch.

regards, Sergei