Horton

Thread

Commits

  1. Add tab-completion for CREATE FOREIGN TABLE.

  1. [PATCH]Add tab completion for foreigh table

    tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com> — 2022-01-11T12:43:21Z

    Hi

Attached a patch to improve the tab completion for foreigh table.

Also modified some DOC description of ALTER TABLE at [1] in according with CREATE INDEX at [2].

In [1], we use "ALTER INDEX ATTACH PARTITION"
In [2], we use "ALTER INDEX ... ATTACH PARTITION"

I think the format in [2] is better.

[1] https://www.postgresql.org/docs/devel/sql-altertable.html
[2] https://www.postgresql.org/docs/devel/sql-createindex.html

Regards,
Tang

  2. Re: [PATCH]Add tab completion for foreigh table

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2022-01-13T03:38:12Z

    
On 2022/01/11 21:43, tanghy.fnst@fujitsu.com wrote:
> Hi
> 
> Attached a patch to improve the tab completion for foreigh table.

Thanks!

Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE FOREIGN TABLE?


> Also modified some DOC description of ALTER TABLE at [1] in according with CREATE INDEX at [2].
> 
> In [1], we use "ALTER INDEX ATTACH PARTITION"
> In [2], we use "ALTER INDEX ... ATTACH PARTITION"
> 
> I think the format in [2] is better.

Agreed.

IMO it's better to make the docs changes in separate patch because they are not directly related to the improvement of tab-completion.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  3. RE: [PATCH]Add tab completion for foreigh table

    tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com> — 2022-01-13T06:57:42Z

    On Thursday, January 13, 2022 12:38 PM, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE
> FOREIGN TABLE?

Thanks for your review. Left bracket completion added.

> IMO it's better to make the docs changes in separate patch because they are not
> directly related to the improvement of tab-completion.

Agreed. The former one patch was divided into two. 
0001 patch, added tab completion for foreign table.
0002 patch, modified some doc description.

Regards,
Tang