RE: [PATCH]Add tab completion for foreigh table

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>

To: Fujii Masao <masao.fujii@oss.nttdata.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2022-01-13T06:57:42Z

Lists: pgsql-hackers

Attachments

v-0001-add-tab-completion-for-PARTITION-OF-when-creating.patch (application/octet-stream) patch v2-0001
v2-0002-Modify-doc-description-for-ALTER-TABLE-in-accordi.patch (application/octet-stream) patch v2-0002

On Thursday, January 13, 2022 12:38 PM, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE
> FOREIGN TABLE?

Thanks for your review. Left bracket completion added.

> IMO it's better to make the docs changes in separate patch because they are not
> directly related to the improvement of tab-completion.

Agreed. The former one patch was divided into two. 
0001 patch, added tab completion for foreign table.
0002 patch, modified some doc description.

Regards,
Tang

Commits

Add tab-completion for CREATE FOREIGN TABLE.
- 74527c3e022d 15.0 landed