Horton

Re: [PATCH]Add tab completion for foreigh table

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-13T03:38:12Z
Lists: pgsql-hackers 

On 2022/01/11 21:43, tanghy.fnst@fujitsu.com wrote:
> Hi
> 
> Attached a patch to improve the tab completion for foreigh table.

Thanks!

Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE FOREIGN TABLE?


> Also modified some DOC description of ALTER TABLE at [1] in according with CREATE INDEX at [2].
> 
> In [1], we use "ALTER INDEX ATTACH PARTITION"
> In [2], we use "ALTER INDEX ... ATTACH PARTITION"
> 
> I think the format in [2] is better.

Agreed.

IMO it's better to make the docs changes in separate patch because they are not directly related to the improvement of tab-completion.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Add tab-completion for CREATE FOREIGN TABLE.