Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix incorrect IndexOptInfo header comment

  1. Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

    Junwang Zhao <zhjwpku@gmail.com> — 2025-11-22T12:44:13Z

    Hi,

Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
struct comments fail to express this, it says:

indexkeys[], indexcollations[] each have ncolumns entries.

So we should polish this description. trivial patch attached.

-- 
Regards
Junwang Zhao

  2. Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

    David Rowley <dgrowleyml@gmail.com> — 2025-11-23T22:52:21Z

    On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> struct comments fail to express this, it says:
>
> indexkeys[], indexcollations[] each have ncolumns entries.
>
> So we should polish this description. trivial patch attached.

Thanks. I agree with the patch.  We should probably mention
canreturn[] too. I can take care of this.

David

  3. Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

    Junwang Zhao <zhjwpku@gmail.com> — 2025-11-24T01:57:03Z

    On Mon, Nov 24, 2025 at 6:52 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> > struct comments fail to express this, it says:
> >
> > indexkeys[], indexcollations[] each have ncolumns entries.
> >
> > So we should polish this description. trivial patch attached.
>
> Thanks. I agree with the patch.  We should probably mention
> canreturn[] too. I can take care of this.

Agreed. Thanks for taking care of this.

>
> David



-- 
Regards
Junwang Zhao

  4. Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

    David Rowley <dgrowleyml@gmail.com> — 2025-11-24T04:03:04Z

    On Mon, 24 Nov 2025 at 14:57, Junwang Zhao <zhjwpku@gmail.com> wrote:
>
> On Mon, Nov 24, 2025 at 6:52 AM David Rowley <dgrowleyml@gmail.com> wrote:
> >
> > On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> > Thanks. I agree with the patch.  We should probably mention
> > canreturn[] too. I can take care of this.
>
> Agreed. Thanks for taking care of this.

Pushed.

David