Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

Junwang Zhao <zhjwpku@gmail.com>

From: Junwang Zhao <zhjwpku@gmail.com>

To: David Rowley <dgrowleyml@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-24T01:57:03Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix incorrect IndexOptInfo header comment
- ea36c2f6a981 14.21 landed
- ea757e801296 15.16 landed
- 14cdab029287 16.12 landed
- 232e0f5de41b 17.8 landed
- f4e68a32a0cc 18.2 landed
- 07d1dc3aebe4 19 (unreleased) landed

On Mon, Nov 24, 2025 at 6:52 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> > struct comments fail to express this, it says:
> >
> > indexkeys[], indexcollations[] each have ncolumns entries.
> >
> > So we should polish this description. trivial patch attached.
>
> Thanks. I agree with the patch.  We should probably mention
> canreturn[] too. I can take care of this.

Agreed. Thanks for taking care of this.

>
> David



-- 
Regards
Junwang Zhao