Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
David Rowley <dgrowleyml@gmail.com>
From: David Rowley <dgrowleyml@gmail.com>
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-23T22:52:21Z
Lists: pgsql-hackers
On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote: > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but > struct comments fail to express this, it says: > > indexkeys[], indexcollations[] each have ncolumns entries. > > So we should polish this description. trivial patch attached. Thanks. I agree with the patch. We should probably mention canreturn[] too. I can take care of this. David