Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Indent fix_path_separator() header properly.

  2. Make new event trigger facility actually do something.

  1. Some whitespaces in utility.c

    Michael Paquier <michael.paquier@gmail.com> — 2012-09-04T04:57:37Z

    Hi all,

I found some whitespace characters in utility.c introduced by commit
3a0e4d3.
Please find attached a patch fixing that which can be applied on postgres
master (commit 2f0c7d5).

Thanks,
-- 
Michael Paquier
http://michael.otacoo.com

  2. Re: Some whitespaces in utility.c

    Magnus Hagander <magnus@hagander.net> — 2012-09-04T07:21:02Z

    On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Hi all,
>
> I found some whitespace characters in utility.c introduced by commit
> 3a0e4d3.
> Please find attached a patch fixing that which can be applied on postgres
> master (commit 2f0c7d5).

That probably exists in many other places in the source as well, but
it's certainly fairly ugly. So I see nothing wrong cleaning it up whe
nspotted.

Thus, patch applied, thanks!

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

  3. Re: Some whitespaces in utility.c

    Tom Lane <tgl@sss.pgh.pa.us> — 2012-09-04T14:35:07Z

    Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> I found some whitespace characters in utility.c introduced by commit
>> 3a0e4d3.
>> Please find attached a patch fixing that which can be applied on postgres
>> master (commit 2f0c7d5).

> That probably exists in many other places in the source as well, but
> it's certainly fairly ugly. So I see nothing wrong cleaning it up whe
> nspotted.

Just as a note: we generally leave it to pgindent to fix this sort of
thing.  I'm not sure it's worth the effort of submitting manual patches
for, unless you have reason to think the next pgindent run won't fix it.

			regards, tom lane

  4. Re: Some whitespaces in utility.c

    Michael Paquier <michael.paquier@gmail.com> — 2012-09-04T22:40:38Z

    On Tue, Sep 4, 2012 at 11:35 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Magnus Hagander <magnus@hagander.net> writes:
> > On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier
> > <michael.paquier@gmail.com> wrote:
> >> I found some whitespace characters in utility.c introduced by commit
> >> 3a0e4d3.
> >> Please find attached a patch fixing that which can be applied on
> postgres
> >> master (commit 2f0c7d5).
>
> > That probably exists in many other places in the source as well, but
> > it's certainly fairly ugly. So I see nothing wrong cleaning it up whe
> > nspotted.
>
> Just as a note: we generally leave it to pgindent to fix this sort of
> thing.  I'm not sure it's worth the effort of submitting manual patches
> for, unless you have reason to think the next pgindent run won't fix it.
>
Understood, thanks for telling about that.
I just read some code and bumped into it, for sure doing such maintenance
all at once with pgindent saves time and effort.
-- 
Michael Paquier
http://michael.otacoo.com