Re: Some whitespaces in utility.c
Michael Paquier <michael.paquier@gmail.com>
From: Michael Paquier <michael.paquier@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2012-09-04T22:40:38Z
Lists: pgsql-hackers
On Tue, Sep 4, 2012 at 11:35 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Magnus Hagander <magnus@hagander.net> writes: > > On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier > > <michael.paquier@gmail.com> wrote: > >> I found some whitespace characters in utility.c introduced by commit > >> 3a0e4d3. > >> Please find attached a patch fixing that which can be applied on > postgres > >> master (commit 2f0c7d5). > > > That probably exists in many other places in the source as well, but > > it's certainly fairly ugly. So I see nothing wrong cleaning it up whe > > nspotted. > > Just as a note: we generally leave it to pgindent to fix this sort of > thing. I'm not sure it's worth the effort of submitting manual patches > for, unless you have reason to think the next pgindent run won't fix it. > Understood, thanks for telling about that. I just read some code and bumped into it, for sure doing such maintenance all at once with pgindent saves time and effort. -- Michael Paquier http://michael.otacoo.com
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Indent fix_path_separator() header properly.
- 2f0c7d585412 9.3.0 cited
-
Make new event trigger facility actually do something.
- 3a0e4d36ebd7 9.3.0 cited