Re: Some whitespaces in utility.c

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2012-09-04T14:35:07Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> I found some whitespace characters in utility.c introduced by commit
>> 3a0e4d3.
>> Please find attached a patch fixing that which can be applied on postgres
>> master (commit 2f0c7d5).

> That probably exists in many other places in the source as well, but
> it's certainly fairly ugly. So I see nothing wrong cleaning it up whe
> nspotted.

Just as a note: we generally leave it to pgindent to fix this sort of
thing.  I'm not sure it's worth the effort of submitting manual patches
for, unless you have reason to think the next pgindent run won't fix it.

			regards, tom lane


Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Indent fix_path_separator() header properly.

  2. Make new event trigger facility actually do something.