Horton

Thread

Commits

  1. Update outdated comments in nodeAgg.c.

  2. Support hashed aggregation with grouping sets.

  1. Fix outdated code comments in nodeAgg.c

    Zhang Mingli <zmlpostgres@gmail.com> — 2025-02-09T15:14:51Z

    Hi,

By reading the codes in nodeAgg.c, I found that some comments are outdated.
The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
I've adjusted the comments to refer to the correct function to make it clear.

--
Zhang Mingli
HashData

  2. Re: Fix outdated code comments in nodeAgg.c

    Richard Guo <guofenglinux@gmail.com> — 2025-02-10T08:45:38Z

    On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> By reading the codes in nodeAgg.c, I found that some comments are outdated.
> The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> I've adjusted the comments to refer to the correct function to make it clear.

LGTM.  This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard

  3. Re: Fix outdated code comments in nodeAgg.c

    Zhang Mingli <zmlpostgres@gmail.com> — 2025-02-18T12:11:22Z

    On Feb 10, 2025 at 16:45 +0800, Richard Guo <guofenglinux@gmail.com>, wrote:
> On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> > By reading the codes in nodeAgg.c, I found that some comments are outdated.
> > The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> > I've adjusted the comments to refer to the correct function to make it clear.
>
> LGTM. This seems to be an oversight from 200f6100a, in which the
> function lookup_hash_entry() was removed.
>
> Thanks
> Richard
Hi,

Thanks for review, added it to commitfest https://commitfest.postgresql.org/patch/5580/


--
Zhang Mingli
HashData

  4. Re: Fix outdated code comments in nodeAgg.c

    Jeff Davis <pgsql@j-davis.com> — 2025-02-18T18:39:25Z

    On Tue, 2025-02-18 at 20:11 +0800, Zhang Mingli wrote:
> Thanks for review, added it to
> commitfest https://commitfest.postgresql.org/patch/5580/

Committed. Thank you!

Regards,
	Jeff Davis