Horton

Re: Fix outdated code comments in nodeAgg.c

Richard Guo <guofenglinux@gmail.com>

View thread View on postgr.es
From: Richard Guo <guofenglinux@gmail.com>
To: Zhang Mingli <zmlpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-10T08:45:38Z
Lists: pgsql-hackers 
On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> By reading the codes in nodeAgg.c, I found that some comments are outdated.
> The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> I've adjusted the comments to refer to the correct function to make it clear.

LGTM.  This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard

Commits

  1. Update outdated comments in nodeAgg.c.

  2. Support hashed aggregation with grouping sets.