Horton

Re: Fix outdated code comments in nodeAgg.c

Zhang Mingli <zmlpostgres@gmail.com>

View thread View on postgr.es
From: Zhang Mingli <zmlpostgres@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-18T12:11:22Z
Lists: pgsql-hackers 
On Feb 10, 2025 at 16:45 +0800, Richard Guo <guofenglinux@gmail.com>, wrote:
> On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> > By reading the codes in nodeAgg.c, I found that some comments are outdated.
> > The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> > I've adjusted the comments to refer to the correct function to make it clear.
>
> LGTM. This seems to be an oversight from 200f6100a, in which the
> function lookup_hash_entry() was removed.
>
> Thanks
> Richard
Hi,

Thanks for review, added it to commitfest https://commitfest.postgresql.org/patch/5580/


--
Zhang Mingli
HashData

Commits

  1. Update outdated comments in nodeAgg.c.

  2. Support hashed aggregation with grouping sets.