Horton

Thread

Commits

  1. psql: Improve tab completion for ALTER TABLE on identity columns

  1. [PATCH] Improve tab completion for ALTER TABLE on identity columns

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2022-10-12T14:18:46Z

    Hi Hackers,

I noticed that psql has no tab completion around identity columns in
ALTER TABLE, so here's some patches for that.

In passing, I also added completion for ALTER SEQUECNE … START, which was
missing for some reason.

- ilmari

  2. Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2022-10-14T14:31:26Z

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> writes:

> Hi Hackers,
>
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.

Added to the next commit fest:

https://commitfest.postgresql.org/40/3947/

- ilmari

  3. Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

    Matheus Alcantara <mths.dev@pm.me> — 2022-10-25T22:45:20Z

    > Hi Hackers,
> 
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.
> 
> In passing, I also added completion for ALTER SEQUECNE … START, which was
> missing for some reason.
> 
> - ilmari

Hi ilmari

I've tested all 4 of your patches, and all of them seem to work as expected.

This is my first time reviewing a patch, so let's see if more experience 
hackers has anything more to say about these patches, but at first they 
seem correct to me.


--
Matheus Alcantara

  4. Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2022-11-01T11:19:54Z

    On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
> 
> Added to the next commit fest:
> 
> https://commitfest.postgresql.org/40/3947/

Committed.

  5. Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2022-11-01T11:20:54Z

    On 26.10.22 00:45, Matheus Alcantara wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>>
>> In passing, I also added completion for ALTER SEQUECNE … START, which was
>> missing for some reason.

> I've tested all 4 of your patches, and all of them seem to work as expected.
> 
> This is my first time reviewing a patch, so let's see if more experience
> hackers has anything more to say about these patches, but at first they
> seem correct to me.

This was sensible for a first review.  Thanks for you help.

  6. Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

    Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> — 2022-11-01T11:29:21Z

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:

> On 14.10.22 16:31, Dagfinn Ilmari Mannsåker wrote:
>>> I noticed that psql has no tab completion around identity columns in
>>> ALTER TABLE, so here's some patches for that.
>> Added to the next commit fest:
>> https://commitfest.postgresql.org/40/3947/
>
> Committed.

Thanks!

- ilmari