Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

Matheus Alcantara <mths.dev@pm.me>

From: Matheus Alcantara <mths.dev@pm.me>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-10-25T22:45:20Z
Lists: pgsql-hackers
> Hi Hackers,
> 
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.
> 
> In passing, I also added completion for ALTER SEQUECNE … START, which was
> missing for some reason.
> 
> - ilmari

Hi ilmari

I've tested all 4 of your patches, and all of them seem to work as expected.

This is my first time reviewing a patch, so let's see if more experience 
hackers has anything more to say about these patches, but at first they 
seem correct to me.


--
Matheus Alcantara




Commits

  1. psql: Improve tab completion for ALTER TABLE on identity columns