Horton

Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Matheus Alcantara <mths.dev@pm.me>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-01T11:20:54Z
Lists: pgsql-hackers 
On 26.10.22 00:45, Matheus Alcantara wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>>
>> In passing, I also added completion for ALTER SEQUECNE … START, which was
>> missing for some reason.

> I've tested all 4 of your patches, and all of them seem to work as expected.
> 
> This is my first time reviewing a patch, so let's see if more experience
> hackers has anything more to say about these patches, but at first they
> seem correct to me.

This was sensible for a first review.  Thanks for you help.

Commits

  1. psql: Improve tab completion for ALTER TABLE on identity columns