Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_combinebackup: Fix incorrect code documentation

  1. pg_combinebackup: correct code comment.

    amul sul <sulamul@gmail.com> — 2025-04-15T04:22:19Z

    Hi,
Cc: Robert

Attached is a patch that corrects the code comment for
process_directory_recursively() in pg_combinebackup, where the comment
incorrectly refers to "output_directory" instead of the intended
"input_directory".

--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

  2. Re: pg_combinebackup: correct code comment.

    Daniel Gustafsson <daniel@yesql.se> — 2025-04-15T07:45:32Z

    > On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:

> Attached is a patch that corrects the code comment for
> process_directory_recursively() in pg_combinebackup, where the comment
> incorrectly refers to "output_directory" instead of the intended
> "input_directory".

Agreed.  The second paragraph in the comment also seem a bit odd, how about the
below while we are there fixing things?

- * If processing is a user-defined tablespace, the tsoid should be the OID
+ * If processing a user-defined tablespace, the tsoid should be the OID

--
Daniel Gustafsson

  3. Re: pg_combinebackup: correct code comment.

    amul sul <sulamul@gmail.com> — 2025-04-15T10:41:19Z

    On Tue, Apr 15, 2025 at 1:16 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:
>
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed.  The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID
>

+1

Regards,
Amul

  4. Re: pg_combinebackup: correct code comment.

    Robert Haas <robertmhaas@gmail.com> — 2025-04-15T12:41:33Z

    On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed.  The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID

Yeah, I agree with both of these changes. Feel free to commit, unless
you want me to do it.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  5. Re: pg_combinebackup: correct code comment.

    Daniel Gustafsson <daniel@yesql.se> — 2025-04-15T13:41:22Z

    > On 15 Apr 2025, at 14:41, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>> On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:
>>> Attached is a patch that corrects the code comment for
>>> process_directory_recursively() in pg_combinebackup, where the comment
>>> incorrectly refers to "output_directory" instead of the intended
>>> "input_directory".
>> 
>> Agreed.  The second paragraph in the comment also seem a bit odd, how about the
>> below while we are there fixing things?
>> 
>> - * If processing is a user-defined tablespace, the tsoid should be the OID
>> + * If processing a user-defined tablespace, the tsoid should be the OID
> 
> Yeah, I agree with both of these changes. Feel free to commit, unless
> you want me to do it.

No worries, I had this staged anyways from looking at Amul's patch so done as
7ae13170ba5 with a backpatch to 17 as it was a documentation fix and not just a
typo fix.

--
Daniel Gustafsson