Re: pg_combinebackup: correct code comment.

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Daniel Gustafsson <daniel@yesql.se>

Cc: Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-04-15T12:41:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_combinebackup: Fix incorrect code documentation
- fb9ec9cf7926 17.5 landed
- 7ae13170ba55 18.0 landed

On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul@gmail.com> wrote:
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed.  The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID

Yeah, I agree with both of these changes. Feel free to commit, unless
you want me to do it.

-- 
Robert Haas
EDB: http://www.enterprisedb.com