Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add missing keywords to gram.y's unreserved_keywords list.

  1. pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-03-08T21:44:28Z

    Add missing keywords to gram.y's unreserved_keywords list.

We really need an automated check for this ... and did VALIDATE really
need to become a keyword at all, rather than picking some other syntax
using existing keywords?

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3f7d24da16d32ad0fa5abf04b669e86a7d458160

Modified Files
--------------
src/backend/parser/gram.y |    2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

  2. Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Robert Haas <robertmhaas@gmail.com> — 2011-03-11T18:59:40Z

    On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Add missing keywords to gram.y's unreserved_keywords list.
>
> We really need an automated check for this ... and did VALIDATE really
> need to become a keyword at all, rather than picking some other syntax
> using existing keywords?

I think we ought to try to do something about this, so that VALIDATE
doesn't need to become a keyword.

How about instead of VALIDATE CONSTRAINT we simply write ALTER
CONSTRAINT ... VALID?  (Patch attached, passes make check.)

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  3. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Alvaro Herrera <alvherre@commandprompt.com> — 2011-03-11T19:29:38Z

    Excerpts from Robert Haas's message of vie mar 11 15:59:40 -0300 2011:
> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Add missing keywords to gram.y's unreserved_keywords list.
> >
> > We really need an automated check for this ... and did VALIDATE really
> > need to become a keyword at all, rather than picking some other syntax
> > using existing keywords?
> 
> I think we ought to try to do something about this, so that VALIDATE
> doesn't need to become a keyword.
> 
> How about instead of VALIDATE CONSTRAINT we simply write ALTER
> CONSTRAINT ... VALID?  (Patch attached, passes make check.)

Please make-check the docs too.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

  4. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> — 2011-03-11T19:39:06Z

    On 11.03.2011 20:59, Robert Haas wrote:
> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane<tgl@sss.pgh.pa.us>  wrote:
>> Add missing keywords to gram.y's unreserved_keywords list.
>>
>> We really need an automated check for this ... and did VALIDATE really
>> need to become a keyword at all, rather than picking some other syntax
>> using existing keywords?
>
> I think we ought to try to do something about this, so that VALIDATE
> doesn't need to become a keyword.
>
> How about instead of VALIDATE CONSTRAINT we simply write ALTER
> CONSTRAINT ... VALID?  (Patch attached, passes make check.)

ALTER CONSTRAINT ... VALID sounds like it just marks the constraint as 
valid. "VALIDATE CONSTRAINT" sounds like it scans and checks that the 
constraint is valid.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

  5. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Robert Haas <robertmhaas@gmail.com> — 2011-03-11T19:40:34Z

    On Fri, Mar 11, 2011 at 2:39 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> On 11.03.2011 20:59, Robert Haas wrote:
>>
>> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane<tgl@sss.pgh.pa.us>  wrote:
>>>
>>> Add missing keywords to gram.y's unreserved_keywords list.
>>>
>>> We really need an automated check for this ... and did VALIDATE really
>>> need to become a keyword at all, rather than picking some other syntax
>>> using existing keywords?
>>
>> I think we ought to try to do something about this, so that VALIDATE
>> doesn't need to become a keyword.
>>
>> How about instead of VALIDATE CONSTRAINT we simply write ALTER
>> CONSTRAINT ... VALID?  (Patch attached, passes make check.)
>
> ALTER CONSTRAINT ... VALID sounds like it just marks the constraint as
> valid. "VALIDATE CONSTRAINT" sounds like it scans and checks that the
> constraint is valid.

Yeah, it's a little awkward, but I think it's still better than adding
another keyword.  Any other ideas for wording?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  6. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    David Christensen <david@endpoint.com> — 2011-03-11T19:50:44Z

    On Mar 11, 2011, at 1:40 PM, Robert Haas wrote:

> On Fri, Mar 11, 2011 at 2:39 PM, Heikki Linnakangas
> <heikki.linnakangas@enterprisedb.com> wrote:
>> On 11.03.2011 20:59, Robert Haas wrote:
>>> 
>>> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane<tgl@sss.pgh.pa.us>  wrote:
>>>> 
>>>> Add missing keywords to gram.y's unreserved_keywords list.
>>>> 
>>>> We really need an automated check for this ... and did VALIDATE really
>>>> need to become a keyword at all, rather than picking some other syntax
>>>> using existing keywords?
>>> 
>>> I think we ought to try to do something about this, so that VALIDATE
>>> doesn't need to become a keyword.
>>> 
>>> How about instead of VALIDATE CONSTRAINT we simply write ALTER
>>> CONSTRAINT ... VALID?  (Patch attached, passes make check.)
>> 
>> ALTER CONSTRAINT ... VALID sounds like it just marks the constraint as
>> valid. "VALIDATE CONSTRAINT" sounds like it scans and checks that the
>> constraint is valid.
> 
> Yeah, it's a little awkward, but I think it's still better than adding
> another keyword.  Any other ideas for wording?


CHECK VALID?

Regards,

David
--
David Christensen
End Point Corporation
david@endpoint.com

  7. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Andrew Dunstan <andrew@dunslane.net> — 2011-03-11T19:56:13Z

    
On 03/11/2011 02:50 PM, David Christensen wrote:
> On Mar 11, 2011, at 1:40 PM, Robert Haas wrote:
>
>> On Fri, Mar 11, 2011 at 2:39 PM, Heikki Linnakangas
>> <heikki.linnakangas@enterprisedb.com>  wrote:
>>> On 11.03.2011 20:59, Robert Haas wrote:
>>>> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane<tgl@sss.pgh.pa.us>   wrote:
>>>>> Add missing keywords to gram.y's unreserved_keywords list.
>>>>>
>>>>> We really need an automated check for this ... and did VALIDATE really
>>>>> need to become a keyword at all, rather than picking some other syntax
>>>>> using existing keywords?
>>>> I think we ought to try to do something about this, so that VALIDATE
>>>> doesn't need to become a keyword.
>>>>
>>>> How about instead of VALIDATE CONSTRAINT we simply write ALTER
>>>> CONSTRAINT ... VALID?  (Patch attached, passes make check.)
>>> ALTER CONSTRAINT ... VALID sounds like it just marks the constraint as
>>> valid. "VALIDATE CONSTRAINT" sounds like it scans and checks that the
>>> constraint is valid.
>> Yeah, it's a little awkward, but I think it's still better than adding
>> another keyword.  Any other ideas for wording?
>
> CHECK VALID?
>
>


SET VALID? (c.f. SET NULL).

cheers

andrew

  8. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-03-11T19:59:46Z

    Andrew Dunstan <andrew@dunslane.net> writes:
> On 03/11/2011 02:50 PM, David Christensen wrote:
>> On Mar 11, 2011, at 1:40 PM, Robert Haas wrote:
>>> ALTER CONSTRAINT ... VALID sounds like it just marks the constraint as
>>> valid. "VALIDATE CONSTRAINT" sounds like it scans and checks that the
>>> constraint is valid.

> SET VALID? (c.f. SET NULL).

That sounds the best so far, but maybe we should think about other
phrases altogether (ie, not arising from the word "valid")?  I don't
have any great ideas offhand, just trying to think outside the box.

			regards, tom lane

  9. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Andrew Dunstan <adunstan@postgresql.org> — 2011-03-11T20:00:32Z

    On 03/11/2011 02:56 PM, Andrew Dunstan wrote:
>
>
>
> SET VALID? (c.f. SET NULL).

Of course I mean SET NOT NULL.


Anyway, the full thing would be something like


ALTER TABLE foo SET VALID CONSTRAINT bar;


cheers

andrew

  10. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Robert Haas <robertmhaas@gmail.com> — 2011-03-11T20:08:41Z

    On Fri, Mar 11, 2011 at 3:00 PM, Andrew Dunstan <adunstan@postgresql.org> wrote:
> On 03/11/2011 02:56 PM, Andrew Dunstan wrote:
>>
>>
>>
>> SET VALID? (c.f. SET NULL).
>
> Of course I mean SET NOT NULL.
>
>
> Anyway, the full thing would be something like
>
>
> ALTER TABLE foo SET VALID CONSTRAINT bar;

Or ALTER TABLE foo SET CONSTRAINT bar VALID
Or ALTER TABLE foo ALTER CONSTRAINT bar SET VALID

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  11. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Kevin Grittner <kevin.grittner@wicourts.gov> — 2011-03-11T20:10:05Z

    Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
 
>> SET VALID? (c.f. SET NULL).
> 
> That sounds the best so far, but maybe we should think about other
> phrases altogether (ie, not arising from the word "valid")?  I
> don't have any great ideas offhand, just trying to think outside
> the box.
 
At the risk of adding yet another meaning to an
already-heavily-worked word, ANALYZE?
 
-Kevin

  12. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Robert Haas <robertmhaas@gmail.com> — 2011-03-15T15:42:14Z

    On Fri, Mar 11, 2011 at 3:10 PM, Kevin Grittner
<Kevin.Grittner@wicourts.gov> wrote:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>
>>> SET VALID? (c.f. SET NULL).
>>
>> That sounds the best so far, but maybe we should think about other
>> phrases altogether (ie, not arising from the word "valid")?  I
>> don't have any great ideas offhand, just trying to think outside
>> the box.
>
> At the risk of adding yet another meaning to an
> already-heavily-worked word, ANALYZE?

Well, we don't seem to really have consensus around anything in
particular here.  Should we just leave it alone, or is this worth
spending more effort on?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  13. Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

    Tom Lane <tgl@sss.pgh.pa.us> — 2011-03-15T15:46:15Z

    Robert Haas <robertmhaas@gmail.com> writes:
> Well, we don't seem to really have consensus around anything in
> particular here.  Should we just leave it alone, or is this worth
> spending more effort on?

I haven't seen any suggestions yet that don't seem inferior to the
existing command name (ie, VALIDATE).  I'm inclined to leave it alone.
Your recent hack on CREATE ROLE bought more than changing this would.

			regards, tom lane