Re: Re: [COMMITTERS] pgsql: Add missing keywords to gram.y's unreserved_keywords list.

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2011-03-11T19:29:38Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add missing keywords to gram.y's unreserved_keywords list.
- 3f7d24da16d3 9.1.0 cited

Excerpts from Robert Haas's message of vie mar 11 15:59:40 -0300 2011:
> On Tue, Mar 8, 2011 at 4:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Add missing keywords to gram.y's unreserved_keywords list.
> >
> > We really need an automated check for this ... and did VALIDATE really
> > need to become a keyword at all, rather than picking some other syntax
> > using existing keywords?
> 
> I think we ought to try to do something about this, so that VALIDATE
> doesn't need to become a keyword.
> 
> How about instead of VALIDATE CONSTRAINT we simply write ALTER
> CONSTRAINT ... VALID?  (Patch attached, passes make check.)

Please make-check the docs too.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support