Thread

1. Re: top-level DML under CTEs

   Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi> — 2010-10-05T08:55:37Z

   (Oops, this didn't go to -HACKERS)
   
   On 2010-10-04 2:46 PM +0300, Erik Rijkers wrote:
   > (HEAD from git://git.postgresql.org/git/postgresql.git)
   >
   > The patch applies only with error.
   > If that error is ignored, the regression 'with' test failes.
   > If that is also ignored, it runs.
   
   This patch conflicted with Tom's WITH .. INSERT change.  I tweaked the
   patch just a bit and it now passes all regression tests so I can review
   it.  New version attached for documentation purposes.
   
   
   Regards,
   Marko Tiikkaja
   

2. Re: top-level DML under CTEs

   Hitoshi Harada <umi.tanuki@gmail.com> — 2010-10-05T12:37:52Z

   2010/10/5 Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>:
   > (Oops, this didn't go to -HACKERS)
   >
   > On 2010-10-04 2:46 PM +0300, Erik Rijkers wrote:
   >>
   >> (HEAD from git://git.postgresql.org/git/postgresql.git)
   >>
   >> The patch applies only with error.
   >> If that error is ignored, the regression 'with' test failes.
   >> If that is also ignored, it runs.
   >
   > This patch conflicted with Tom's WITH .. INSERT change.  I tweaked the
   > patch just a bit and it now passes all regression tests so I can review
   > it.  New version attached for documentation purposes.
   
   Thank you, I didn't notice that commit. In your last patch, the
   snippet to add errhint() and ref/insert sgml is unnecessary since it
   was for INSERT ... VALUES fix.
   
   Regards,
   
   
   -- 
   Hitoshi Harada
   

3. Re: top-level DML under CTEs

   Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi> — 2010-10-05T15:29:31Z

   On 2010-10-05 3:37 PM +0300, Hitoshi Harada wrote:
   > 2010/10/5 Marko Tiikkaja<marko.tiikkaja@cs.helsinki.fi>:
   >> This patch conflicted with Tom's WITH .. INSERT change.  I tweaked the
   >> patch just a bit and it now passes all regression tests so I can review
   >> it.  New version attached for documentation purposes.
   >
   > Thank you, I didn't notice that commit. In your last patch, the
   > snippet to add errhint() and ref/insert sgml is unnecessary since it
   > was for INSERT ... VALUES fix.
   
   The patch seems to work for all cases I can think of.
   
   I'm going to mark this one ready for committer.
   
   
   Regards,
   Marko Tiikkaja
   
   

4. Re: top-level DML under CTEs

   Tom Lane <tgl@sss.pgh.pa.us> — 2010-10-16T00:00:04Z

   Hitoshi Harada <umi.tanuki@gmail.com> writes:
   > 2010/10/5 Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>:
   >> This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
   >> patch just a bit and it now passes all regression tests so I can review
   >> it. New version attached for documentation purposes.
   
   > Thank you, I didn't notice that commit. In your last patch, the
   > snippet to add errhint() and ref/insert sgml is unnecessary since it
   > was for INSERT ... VALUES fix.
   
   Committed with minor fixes (mostly documentation improvements).
   
   			regards, tom lane