Re: top-level DML under CTEs

Hitoshi Harada <umi.tanuki@gmail.com>

View thread

From: Hitoshi Harada <umi.tanuki@gmail.com>

To: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

Cc: Erik Rijkers <er@xs4all.nl>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2010-10-05T12:37:52Z

Lists: pgsql-hackers

Attachments

toplevel-dml-cte.20101005.diff (application/octet-stream) patch

2010/10/5 Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>:
> (Oops, this didn't go to -HACKERS)
>
> On 2010-10-04 2:46 PM +0300, Erik Rijkers wrote:
>>
>> (HEAD from git://git.postgresql.org/git/postgresql.git)
>>
>> The patch applies only with error.
>> If that error is ignored, the regression 'with' test failes.
>> If that is also ignored, it runs.
>
> This patch conflicted with Tom's WITH .. INSERT change.  I tweaked the
> patch just a bit and it now passes all regression tests so I can review
> it.  New version attached for documentation purposes.

Thank you, I didn't notice that commit. In your last patch, the
snippet to add errhint() and ref/insert sgml is unnecessary since it
was for INSERT ... VALUES fix.

Regards,


-- 
Hitoshi Harada