Re: top-level DML under CTEs

Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>

From: Marko Tiikkaja <marko.tiikkaja@cs.helsinki.fi>
To: Hitoshi Harada <umi.tanuki@gmail.com>
Cc: Erik Rijkers <er@xs4all.nl>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-10-05T15:29:31Z
Lists: pgsql-hackers
On 2010-10-05 3:37 PM +0300, Hitoshi Harada wrote:
> 2010/10/5 Marko Tiikkaja<marko.tiikkaja@cs.helsinki.fi>:
>> This patch conflicted with Tom's WITH .. INSERT change.  I tweaked the
>> patch just a bit and it now passes all regression tests so I can review
>> it.  New version attached for documentation purposes.
>
> Thank you, I didn't notice that commit. In your last patch, the
> snippet to add errhint() and ref/insert sgml is unnecessary since it
> was for INSERT ... VALUES fix.

The patch seems to work for all cases I can think of.

I'm going to mark this one ready for committer.


Regards,
Marko Tiikkaja