Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Create executor and planner-backend support for decoupled heap and index

  1. [PATCH] Update comment in nodeBitmapHeapscan.c

    Anton Haglund <antonh@accum.se> — 2025-12-09T13:04:08Z

    Remove comment about nonexisting ExecBitmapHeapNext.
---
 src/backend/executor/nodeBitmapHeapscan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
index bf24f3d7fe0..8c05c728f1a 100644
--- a/src/backend/executor/nodeBitmapHeapscan.c
+++ b/src/backend/executor/nodeBitmapHeapscan.c
@@ -28,7 +28,6 @@
 /*
  * INTERFACE ROUTINES
  *		ExecBitmapHeapScan			scans a relation using bitmap info
- *		ExecBitmapHeapNext			workhorse for above
  *		ExecInitBitmapHeapScan		creates and initializes state info.
  *		ExecReScanBitmapHeapScan	prepares to rescan the plan.
  *		ExecEndBitmapHeapScan		releases all storage.
-- 
2.34.1

  2. Re: [PATCH] Update comment in nodeBitmapHeapscan.c

    Daniel Gustafsson <dgustafsson@postgresql.org> — 2025-12-09T13:13:32Z

    > On 9 Dec 2025, at 14:04, Anton Haglund <antonh@accum.se> wrote:
> 
> Remove comment about nonexisting ExecBitmapHeapNext.
> ---
> src/backend/executor/nodeBitmapHeapscan.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
> index bf24f3d7fe0..8c05c728f1a 100644
> --- a/src/backend/executor/nodeBitmapHeapscan.c
> +++ b/src/backend/executor/nodeBitmapHeapscan.c
> @@ -28,7 +28,6 @@
> /*
>  * INTERFACE ROUTINES
>  * ExecBitmapHeapScan scans a relation using bitmap info
> - * ExecBitmapHeapNext workhorse for above

Judging by the commitlog that function has never existed, and the workhorse
referred to is BitmapHeapNext (which is not part of the interface).

Thanks for your contribution, but in the future please email pgsql-hackers
instead of all committers directly.  We do all our development publically
archived on pgsql-hackers, and you don't even need to be subscribed to send
(but your email will be subject to moderation).

--
Daniel Gustafsson

  3. Re: [PATCH] Update comment in nodeBitmapHeapscan.c

    Anton Haglund <antonh@accum.se> — 2025-12-09T14:02:38Z

    On 2025-12-09 14:13, Daniel Gustafsson wrote:

> > On 9 Dec 2025, at 14:04, Anton Haglund <antonh@accum.se> wrote:
> > 
> > Remove comment about nonexisting ExecBitmapHeapNext.
> > ---
> > src/backend/executor/nodeBitmapHeapscan.c | 1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
> > index bf24f3d7fe0..8c05c728f1a 100644
> > --- a/src/backend/executor/nodeBitmapHeapscan.c
> > +++ b/src/backend/executor/nodeBitmapHeapscan.c
> > @@ -28,7 +28,6 @@
> > /*
> >  * INTERFACE ROUTINES
> >  * ExecBitmapHeapScan scans a relation using bitmap info
> > - * ExecBitmapHeapNext workhorse for above
> 
> Judging by the commitlog that function has never existed, and the workhorse
> referred to is BitmapHeapNext (which is not part of the interface).
> 
> Thanks for your contribution, but in the future please email pgsql-hackers
> instead of all committers directly.  We do all our development publically
> archived on pgsql-hackers, and you don't even need to be subscribed to send
> (but your email will be subject to moderation).
> 
> --
> Daniel Gustafsson

Hi,

The comment was added to src/backend/executor/nodeBitmapHeapscan.c in
commit 4a8c5d0375f17d8d961a280cbb640996aaa8bf0d, by Tom Lane in 2005.
But as you say, there are no traces of that function ever existed.

Best regards,
Anton Haglund

  4. Re: [PATCH] Update comment in nodeBitmapHeapscan.c

    Daniel Gustafsson <daniel@yesql.se> — 2025-12-09T14:37:39Z

    > On 9 Dec 2025, at 15:02, Anton Haglund <antonh@accum.se> wrote:
> On 2025-12-09 14:13, Daniel Gustafsson wrote:
>>> On 9 Dec 2025, at 14:04, Anton Haglund <antonh@accum.se> wrote:

>>> - * ExecBitmapHeapNext workhorse for above
>> 
>> Judging by the commitlog that function has never existed, and the workhorse
>> referred to is BitmapHeapNext (which is not part of the interface).
>> 
>> Thanks for your contribution, but in the future please email pgsql-hackers
>> instead of all committers directly.  We do all our development publically
>> archived on pgsql-hackers, and you don't even need to be subscribed to send
>> (but your email will be subject to moderation).
> 
> The comment was added to src/backend/executor/nodeBitmapHeapscan.c in
> commit 4a8c5d0375f17d8d961a280cbb640996aaa8bf0d, by Tom Lane in 2005.
> But as you say, there are no traces of that function ever existed.

Correct, the function has never existed, it was a typo(ish) in the original
commit that went unnoticed for two decades.  And sorry for missing that you did
indeed email -hackers as well, I missed that when reading the To: line earlier.
Thanks for contributing to postgres!

--
Daniel Gustafsson