Re: [PATCH] Update comment in nodeBitmapHeapscan.c

On 2025-12-09 14:13, Daniel Gustafsson wrote:

> > On 9 Dec 2025, at 14:04, Anton Haglund <antonh@accum.se> wrote:
> > 
> > Remove comment about nonexisting ExecBitmapHeapNext.
> > ---
> > src/backend/executor/nodeBitmapHeapscan.c | 1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
> > index bf24f3d7fe0..8c05c728f1a 100644
> > --- a/src/backend/executor/nodeBitmapHeapscan.c
> > +++ b/src/backend/executor/nodeBitmapHeapscan.c
> > @@ -28,7 +28,6 @@
> > /*
> >  * INTERFACE ROUTINES
> >  * ExecBitmapHeapScan scans a relation using bitmap info
> > - * ExecBitmapHeapNext workhorse for above
> 
> Judging by the commitlog that function has never existed, and the workhorse
> referred to is BitmapHeapNext (which is not part of the interface).
> 
> Thanks for your contribution, but in the future please email pgsql-hackers
> instead of all committers directly.  We do all our development publically
> archived on pgsql-hackers, and you don't even need to be subscribed to send
> (but your email will be subject to moderation).
> 
> --
> Daniel Gustafsson

Hi,

The comment was added to src/backend/executor/nodeBitmapHeapscan.c in
commit 4a8c5d0375f17d8d961a280cbb640996aaa8bf0d, by Tom Lane in 2005.
But as you say, there are no traces of that function ever existed.

Best regards,
Anton Haglund