Horton
Menu

Re: [PATCH] Update comment in nodeBitmapHeapscan.c

Daniel Gustafsson <dgustafsson@postgresql.org>

View thread
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: Anton Haglund <antonh@accum.se>
Cc: Pgsql Hackers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>, Andres Freund <andres@anarazel.de>, Robert Haas <rhaas@postgresql.org>, Melanie Plageman <melanieplageman@gmail.com>, Álvaro Herrera <alvherre@alvh.no-ip.org>, Tomas Vondra <tomas.vondra@postgresql.org>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Kevin Grittner <kgrittn@postgresql.org>, Peter Eisentraut <peter@eisentraut.org>, Amit Kapila <akapila@postgresql.org>, Amit Langote <amitlan@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, David Rowley <drowley@postgresql.org>, Magnus Hagander <magnus@hagander.net>, Thomas Munro <tmunro@postgresql.org>
Date: 2025-12-09T13:13:32Z
Lists: pgsql-hackers 
> On 9 Dec 2025, at 14:04, Anton Haglund <antonh@accum.se> wrote:
> 
> Remove comment about nonexisting ExecBitmapHeapNext.
> ---
> src/backend/executor/nodeBitmapHeapscan.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
> index bf24f3d7fe0..8c05c728f1a 100644
> --- a/src/backend/executor/nodeBitmapHeapscan.c
> +++ b/src/backend/executor/nodeBitmapHeapscan.c
> @@ -28,7 +28,6 @@
> /*
>  * INTERFACE ROUTINES
>  * ExecBitmapHeapScan scans a relation using bitmap info
> - * ExecBitmapHeapNext workhorse for above

Judging by the commitlog that function has never existed, and the workhorse
referred to is BitmapHeapNext (which is not part of the interface).

Thanks for your contribution, but in the future please email pgsql-hackers
instead of all committers directly.  We do all our development publically
archived on pgsql-hackers, and you don't even need to be subscribed to send
(but your email will be subject to moderation).

--
Daniel Gustafsson

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Create executor and planner-backend support for decoupled heap and index