Horton

Thread

Commits

  1. makeArrayTypeName: Remove pointless relation open/close

  2. Support arrays of composite types, including the rowtypes of regular tables

  1. remove unnecessary table_open/close from makeArrayTypeName

    Alvaro Herrera <alvherre@2ndquadrant.com> — 2019-12-18T22:13:26Z

    Commit bc8036fc666a (12 years ago) seems to have introduced an
unnecessary catalog heap_open/close in order to do syscache accesses.
I presume a preliminary version of the patch used sysscans or something.
I don't think that's necessary, so this patch removes it.

(I noticed while reading Paul Jungwirth's patch that changes how this
works.)

-- 
Álvaro Herrera                         Developer, https://www.PostgreSQL.org/

  2. Re: remove unnecessary table_open/close from makeArrayTypeName

    Tom Lane <tgl@sss.pgh.pa.us> — 2019-12-18T22:22:06Z

    Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Commit bc8036fc666a (12 years ago) seems to have introduced an
> unnecessary catalog heap_open/close in order to do syscache accesses.

Huh.  Not sure how that got past me, but I agree it's bogus.

> I presume a preliminary version of the patch used sysscans or something.
> I don't think that's necessary, so this patch removes it.

+1, but please collapse up the whitespace too.

			regards, tom lane

  3. Re: remove unnecessary table_open/close from makeArrayTypeName

    Michael Paquier <michael@paquier.xyz> — 2019-12-19T02:17:18Z

    On Wed, Dec 18, 2019 at 05:22:06PM -0500, Tom Lane wrote:
> +1, but please collapse up the whitespace too.

+1.
--
Michael