remove unnecessary table_open/close from makeArrayTypeName

Alvaro Herrera <alvherre@2ndquadrant.com>

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-12-18T22:13:26Z
Lists: pgsql-hackers

Attachments

Commit bc8036fc666a (12 years ago) seems to have introduced an
unnecessary catalog heap_open/close in order to do syscache accesses.
I presume a preliminary version of the patch used sysscans or something.
I don't think that's necessary, so this patch removes it.

(I noticed while reading Paul Jungwirth's patch that changes how this
works.)

-- 
Álvaro Herrera                         Developer, https://www.PostgreSQL.org/

Commits

  1. makeArrayTypeName: Remove pointless relation open/close

  2. Support arrays of composite types, including the rowtypes of regular tables